Bugfix get_agent_report(arrange_by) in dev
#573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rich-iannone I think this should do it - hope I'm not too late for the next release! (also oops sorry I accidentally created this branch directly upstream, not in my fork 😅) |
|
Thank you so very much for this! I will release soon. Especially since gt 0.11.1 is out (and everything is good here with that release) it's now definitely the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes breakage of
get_agent_report(arrange_by)#572, caused by #565. The fix continues to allow for the flexibility ofget_agent_report()to handle manually dropped/filtered validation rows, as requested in #563To prevent future regression, added unit tests for shuffling, filtering, and shuffling+filtering of rows in agent report.
Related GitHub Issues and PRs
agent$validation_stepto rows ofget_agent_report(agent)#565, Regression inget_agent_report(arrange_by = "severity")#572Checklist
testthatunit tests totests/testthatfor any new functionality.